3 Commits

Author SHA1 Message Date
Erin Call
c08b2035a8 Merge pull request #1 from pelotech/assorted-cleanups
Assorted cleanups
2019-12-16 15:48:27 -08:00
Erin Call
9797f5c8a2 Non-0 exit status on error 2019-12-16 15:46:37 -08:00
Erin Call
173cf374f9 Run linting on an image with golint preinstalled
Running `go get` adds a line to `go.mod` every time, so using a
preinstalled golint avoids churn.
2019-12-16 15:44:46 -08:00
2 changed files with 6 additions and 4 deletions

View File

@@ -9,8 +9,10 @@ steps:
commands: commands:
- go test ./cmd/... ./internal/... - go test ./cmd/... ./internal/...
- go vet ./cmd/... ./internal/... - go vet ./cmd/... ./internal/...
- go get -u golang.org/x/lint/golint - name: lint
- golint ./cmd/... ./internal/... image: cytopia/golint
commands:
- golint -set_exit_status ./cmd/... ./internal/...
- name: build - name: build
image: golang:1.13 image: golang:1.13
commands: commands:

View File

@@ -19,8 +19,8 @@ func main() {
// Make the plan // Make the plan
plan, err := helm.NewPlan(c) plan, err := helm.NewPlan(c)
if err != nil { if err != nil {
fmt.Fprintf(os.Stderr, err.Error()) fmt.Fprintf(os.Stderr, "%w\n", err)
return os.Exit(1)
} }
// Execute the plan // Execute the plan