Replicate most of drone-helm's config

internal/run/help.go

@@ -4,12 +4,20 @@ import (
 	"os"
 )
 
-func Help(args ...string) error {
-	args = append([]string{"help"}, args...)
-
-	cmd := Command(HELM_BIN, args...)
-	cmd.Stdout(os.Stdout)
-	cmd.Stderr(os.Stderr)
-
-	return cmd.Run()
+type Help struct {
+	cmd cmd
+}
+
+func (h *Help) Run() error {
+	return h.cmd.Run()
+}
+
+func NewHelp() *Help {
+	h := Help{}
+
+	h.cmd = Command(HELM_BIN, "help")
+	h.cmd.Stdout(os.Stdout)
+	h.cmd.Stderr(os.Stderr)
+
+	return &h
 }

internal/run/help_test.go

@@ -15,7 +15,7 @@ func TestHelp(t *testing.T) {
 
 	Command = func(path string, args ...string) cmd {
 		assert.Equal(t, HELM_BIN, path)
-		assert.Equal(t, []string{"help", "arg1", "arg2"}, args)
+		assert.Equal(t, []string{"help"}, args)
 		return mCmd
 	}
 	defer func() { Command = originalCommand }()
@@ -28,5 +28,6 @@ func TestHelp(t *testing.T) {
 		Run().
 		Times(1)
 
-	Help("arg1", "arg2")
+	h := NewHelp()
+	h.Run()
 }

internal/run/upgrade.go

@@ -4,12 +4,25 @@ import (
 	"os"
 )
 
-func Upgrade(args ...string) error {
-	args = append([]string{"upgrade"}, args...)
-	cmd := Command(HELM_BIN, args...)
-
-	cmd.Stdout(os.Stdout)
-	cmd.Stderr(os.Stderr)
-
-	return cmd.Run()
+type Upgrade struct {
+	Chart   string
+	Release string
+	cmd     cmd
+}
+
+func (u *Upgrade) Run() error {
+	return u.cmd.Run()
+}
+
+func NewUpgrade(release, chart string) *Upgrade {
+	u := Upgrade{
+		Chart:   chart,
+		Release: release,
+		cmd:     Command(HELM_BIN, "upgrade", "--install", release, chart),
+	}
+
+	u.cmd.Stdout(os.Stdout)
+	u.cmd.Stderr(os.Stderr)
+
+	return &u
 }

internal/run/upgrade_test.go

@@ -6,7 +6,7 @@ import (
 	"testing"
 )
 
-func TestUpgrade(t *testing.T) {
+func TestNewUpgrade(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
 
@@ -15,7 +15,7 @@ func TestUpgrade(t *testing.T) {
 
 	Command = func(path string, args ...string) cmd {
 		assert.Equal(t, HELM_BIN, path)
-		assert.Equal(t, []string{"upgrade", "arg1", "arg2"}, args)
+		assert.Equal(t, []string{"upgrade", "--install", "jonas_brothers_only_human", "at40"}, args)
 
 		return mCmd
 	}
@@ -29,5 +29,6 @@ func TestUpgrade(t *testing.T) {
 		Run().
 		Times(1)
 
-	Upgrade("arg1", "arg2")
+	u := NewUpgrade("jonas_brothers_only_human", "at40")
+	u.Run()
 }